]> dgit.raspbian.org Git - gnome-shell.git/commit
notificationDaemon: Catch exceptions while loading notifications
authorWill Thompson <wjt@endlessm.com>
Wed, 28 Aug 2019 14:38:03 +0000 (15:38 +0100)
committerFlorian Müllner <florian.muellner@gmail.com>
Tue, 3 Sep 2019 01:00:50 +0000 (01:00 +0000)
commite5cde4700f41fd4fd9d5ceeb09f235afd034201e
tree41f2989bc94b1080c076d3bd477d707fd7244f90
parenta207f67f73ea7790f9562b46843c5f83f72973de
notificationDaemon: Catch exceptions while loading notifications

An Endless OS system was found in the wild with a malformed
.local/share/gnome-shell/notifications which causes _loadNotifications()
to raise an exception. This exception was not previously handled and
bubbles all the way out to gnome_shell_plugin_start(), whereupon the
shell exit(1)s. The user could no longer log into their computer.

Handle exceptions from _loadNotifications(), log them, and attempt to
continue. Ensure that this._isLoading is set to 'false' even on error,
so that future calls to _saveNotifications() can overwrite the (corrupt)
state file.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/1552
js/ui/notificationDaemon.js